Expenses chart component

Community feedback

• 

  Jay Khatri•4,250

  @khatri2002Posted about 2 months ago

  Hi @Hermodesign!

  The developed solution looks good!

  It seems you've used a canvas library to render the chart, which looks amazing! However, please note that the sole purpose of this challenge was to build the chart from scratch, as explicitly mentioned in the challenge description.

  Why Building the Chart from Scratch Matters:

  • Using libraries like Chart.js is perfectly valid in complex applications, where the primary focus is on functionality and efficiency.
  • However, building such a component from scratch will truly test and showcase your JavaScript skills. It involves handling DOM manipulations, event listeners, dynamic rendering, and animations without relying on external tools.

  I highly recommend attempting the chart implementation from scratch to align with the challenge objectives.

  Regarding Your GitHub Repository:

  The code in your GitHub repository appears to be the built code (e.g., minified files or bundled outputs). This makes it difficult to read, as Built code is generally optimized for performance, not for readability or review. It prevents reviewers from understanding the logic and structure of your solution.

  1. Push the Actual Source Code: Ensure the original source code (including all files, components, and configurations) is uploaded to the repository. This will allow for a proper review of your implementation.
  2. Avoid Pushing Built Files: Built files are typically ignored in version control using .gitignore. Only push the source files to keep the repository clean.

  ---

  The rest of the solution looks good! Keep up the great work! 🚀

  0