Skip to content
Submitted over 1 year ago

Expenses chart component

Kiran kumar•120
@kiran1095
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Expenses chart component
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Solution retrospective

Hello Everyone,

  • I would love to get some feedback on how I can improve my responsiveness to this page.
  • I also would love to see how I can do better with picking the max value from the array so I can give different colour, which I did but I think their is a better way of doing it.

Thanks.

Community feedback

  • Arseniy•170
    @ArseniyXPosted over 1 year ago

    Hello, not liked so much things to improve

    1. unused comments should be removed
    2. use prettier and es lint to improve the code
    3. don't use outdated framework without good reason
    4. "<div class='bar bar_high' style= 'height:"+ data[i].amount * 3 +"px' data-barValue="+data[i].amount+"></div>" use template literals instead of doing '+' it will more readable
    Marked as helpful
    0
    Kiran kumar•120
    @kiran1095Posted over 1 year ago

    @ArseniyX

    Thanks for the feedback Arseniy. Will try to improve myself and will learn from your feedback .

    Regarding the 3rd point, outdated framework do you mean about the jquery? because I havent used any framework. Thanks.

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord