Expanses Chart Component

Community feedback

• 

  P

  visualdennis•8,375

  @visualdennissPosted over 1 year ago

  Your solution looks great and responds very well to different browser sizes!

  While everything seems to function and work without any issue, one improvement area could be perhaps having the days and their heights not hard coded, instead you can try to have the data passed dynamically. This way your app could scale better in general if later on new and more data were to be added.

  instead of day[0].style.height = "50px" day[1].style.height = "90px" day[2].style.height = "130px" ...

  you can have an array of objects like [ {id: 0, height: 50, day: mon}, {id: 1, height: 70, day: tue}...]and map through that data using map() method etc.

  Hope this helps! Good luck on upcoming challenges :)

  Marked as helpful

  0

  ---

  

  Nino Khurtsidze•400

  @NinunutsiPosted over 1 year ago

  @visualdenniss Thank you!

  0