Exercise 5_column preview card component with SASS

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey there!👋 Here are some suggestions to help improve your code:

  • Along with the Blank Alt Tag, you also want to include the aria-hidden=“true” to your car images/icons to fully remove them from assistive technology.

  • The headings in your component are being used incorrectly. Since the <h1> Heading can only be used once, it is always given to the heading with the highest level of importance. This component has three headings of equal importance, so the best option would be to use an <h2> Heading, since it is reusable and it will give each heading the same level of importance.

  • Your "buttons" were created with the incorrect element. When the user clicks on the button they should directed to a different part of you site. The Anchor Tag will achieve this.

  • Implement a Mobile First approach 📱 > 🖥

  With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.

  If you have any questions or need further clarification, let me know.

  Happy Coding! 👻🎃

  Marked as helpful

  0

  ---

  

  Federico Durante•70

  @fedementrePosted about 2 years ago

  @vcarames Thank you very much! you were very helpful! I will fix my code soon and I hope you can help me in the future too! I love you!

  0
• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hello @fedementre, Congratulations on completing this challenge!

  Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:

  • Add the correct color for the background, that in this case is background-color: #F2F2F2
  • The icon doesn’t have an important role when you think about semantics and the html structure. So you can add aria-hidden=“true” to avoid it being found and read in the accessibility mode/screen readers. These are only decorative items.

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  Federico Durante•70

  @fedementrePosted about 2 years ago

  @correlucas Hi Lucas! Thank you! All your tips are very important for me! I just update background color, I could't find it in the style guide. Thank you so much! Can you better explaine the second point please?

  0