Event-Listener, BEM,SASS

Community feedback

• 

  szam•800

  @k-stopczynskaPosted about 2 years ago

  Hi,

  your solution looks really good, congratulations:)

  Few things I might suggest: Use array methods instead of loops, it's more readable, faster and convenient (e.g. looping through buttons, you could use forEach method which is available for HTML collections and Node lists).

  For Sass: it's a little overkill using Sass for project so small, but when you are using it: look at your modules structure. Here you can find tips how to structure it: https://itnext.io/structuring-your-sass-projects-c8d41fa55ed4. Kevin Powell has also youtube video on this topic.

  And one another thing: with new version of Dart Sass it's not really recommended to use @import. Kevin also has a video on using @use and @forward, it's also available in Sass documentation.

  Hope this helps:)

  Happy coding!

  Marked as helpful

  0

  ---

  

  Louis Browyn•90

  @browynlouisPosted about 2 years ago

  @k-stopczynska please kindly do drop a review on my own project.

  0