Design comparison
Solution retrospective
Hello! I feel as though I did pretty good. I was able to get the title and the creator text to show up as white, but for some reason its not showing on GitHub, its maybe taking a while. But the active for those two are working. Only thing I had trouble with was active for image on card. I maybe was over-thinking it, but I didn't get it to work. Thank you for taking your time in looking at my code!
Community feedback
- @AdrianoEscarabotePosted about 2 years ago
Hi Mgamboa, how are you?
I really liked the result of your project, but I have some tips that I think you will enjoy:
As you know this page is just a component, so it doesn't even need an
h1
! because we don't know how important the other components of the site will be! but it's always good to prevent accessibility errors so I think it would be good for you to add anh1
in this component, besides being a good practice for when you are developing larger sites, don't worry forget abouth1
.A good practice to center content is using
grid
orflex-box
, avoid using margin or padding to make placements, use only in the latter case! we can do it like this:Flex-box:
body { display: flex; align-items: center; justify-content: center; flex-direction: column; min height: 100vh; }
GRID
body { display: grid; min height: 100vh; place-content: center; }
The rest is great!
I hope it helps... 👍
Marked as helpful1@Marianellag1Posted about 2 years ago@AdrianoEscarabote Hello! I'm good thank you, I hope you are good as well! I really appreciate your help. I know I look for the easy way out for these with margin and padding. But I am definitely going to be using these tips in the future! Thank you!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord