Equilibrium-Card

Community feedback

• 

  Adriano•38,040

  @AdrianoEscarabotePosted about 2 years ago

  Hi Mgamboa, how are you?

  I really liked the result of your project, but I have some tips that I think you will enjoy:

  As you know this page is just a component, so it doesn't even need an h1! because we don't know how important the other components of the site will be! but it's always good to prevent accessibility errors so I think it would be good for you to add an h1 in this component, besides being a good practice for when you are developing larger sites, don't worry forget about h1.

  A good practice to center content is using grid or flex-box, avoid using margin or padding to make placements, use only in the latter case! we can do it like this:

  Flex-box:

  body {
      display: flex;
      align-items: center;
      justify-content: center;
      flex-direction: column;
      min height: 100vh;
  }
  

  GRID

  body {
      display: grid;
      min height: 100vh;
      place-content: center;
  }
  

  The rest is great!

  I hope it helps... 👍

  Marked as helpful

  1

  ---

  

  Mgamboa•220

  @Marianellag1Posted almost 2 years ago

  @AdrianoEscarabote Hello! I'm good thank you, I hope you are good as well! I really appreciate your help. I know I look for the easy way out for these with margin and padding. But I am definitely going to be using these tips in the future! Thank you!

  1