Design comparison
SolutionDesign
Community feedback
- @NaveenGumastePosted almost 3 years ago
Hay ! Good Job
These below mentioned tricks will help you remove any Accessibility Issues
-> Add Main tag after body like it should be your container
-> For 1st heading or h1 tag, use header tag and then inside the header put your h1 or h2 etc
-> But use header tag only once in main heading element.
Keep up the good work!
0 - @RioCantrePosted almost 3 years ago
Hello there! Nice job in completing this project. Looking at your solution, I think you should considered the following as well...
- Import the
attribution
style in the CSS file and remove thestyle
tag - Clean the spaces in the code
- Include description to
alt
inimg
tag and should not be empty - Wrap the
main_div
with specific tag likemain
andattribution
withfooter
tag - Add hover state with the design...like the font style, create new rule set with the
.main-title
andspan
and add properties likecolor: cyan
andcursor:pointer
. Include the hover state of the Hero image with the eye icon and background color
Hope this helps and Keep it up!
0 - Import the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord