Equalizer-landing-page-React-TypeScript

Community feedback

• 

  BrunoMoleta•700

  @brunomoletaPosted 7 months ago

  Hi PiriyaLapa,

  I've forked your project to see it closely and sent you a PR on Git Hub with the full review.

  The main changes suggested are:

  • The HTML structure: you use only <section> tags. I substituted them with header, main, and footer.

  Because your Styled-components were named Footer, for example, but they were sections. And that brings little semantic meaning.

  • Images: All <img> tags must have an alt. So I put them in. Even the background image ought to have an empty alt.

  • Pages must always have an <h1>

  Also, I changed the following snippet to the Card component, and nothing but the Logo inside the Header:

         
            <h1>{title}</h1>
            <p>{content}</p>
         
         {shouldRenderVector && <VectorTablet />}
  

  I also advise you to use with caution the % unit at padding and margin for it may lead to weird layouts depending on the screen size. I also change some of that.

  Beyond that, it's not a good practice to use z-index as often as you did. I removed most of it and the result remains.

  There are other tweaks related to the styles. Test them out and compare them to how they were before.

  Last but not least, the format script is added for formatting the project using Prettier.

  Keep the hustle fellow developer

  Best regards from Brazil :)

  0