Equalizer Landing Page

Community feedback

• 

  Natasha Pierre-Louis•280

  @natashaplPosted about 2 years ago

  Hi Glenda. Nice work! I think most issues were already addressed. The only thing I wanted to point out is that the commented message you're using to separate the header from the main tag is causing you page to not be valid HTML. The fix is to remove some of the hyphens since there should only be 2 on each side: Once you're done fixing it, you can regenerate a new report by clicking the "View Report" button above and and then on that page click "Generate Report".

  I hope this is helpful. :)

  Marked as helpful

  1

  ---

  

  P

  Glenda Joyce Reed•1,260

  @Glenda9031Posted about 2 years ago

  @natashapl Do you mean on the 'index.html' page or the 'css' page? Thank you for the feedback!

  1

  

  Natasha Pierre-Louis•280

  @natashaplPosted about 2 years ago

  @Glenda9031 No problem. I tried to show which line of code but this editor keeps erasing it. It's lines 11 and 30 in the index.html page.

  Marked as helpful

  0

  

  P

  Glenda Joyce Reed•1,260

  @Glenda9031Posted about 2 years ago

  @natashapl Thanks a million! I appreciate this so much!!

  0

  

  P

  Glenda Joyce Reed•1,260

  @Glenda9031Posted about 2 years ago

  @natashapl Thanks a million! I appreciate this so much!!

  1

  

  Natasha Pierre-Louis•280

  @natashaplPosted about 2 years ago

  @Glenda9031 You're very welcome :)

  Marked as helpful

  0
• 

  Ahmed Kamel•1,190

  @hmadamkPosted about 2 years ago

  • Well done with the challenge
  • the order does not matter at all but you could make your own convention just for your self mine is like so

  .element{
    display:first;
    all stuff related to the display is here then some space
  
    the background and color and border and outline and box-shadow text-shadow
  
    the font and font-weight 
   
    margin and padding goes here
   
    transition and transform
  
  }
  

  • to pass the accessibility test use <main class="container">or wrap the div with main make sure that all of your page is contained by a landmark examples of landmarks are

  header for the top section
  main for your main section
  section with aria-label to describe why you added this section
  footer for the bottom section
  
  

  Marked as helpful

  1

  ---

  

  P

  Glenda Joyce Reed•1,260

  @Glenda9031Posted about 2 years ago

  @hmadamk Thank you so much!

  1

  

  P

  Glenda Joyce Reed•1,260

  @Glenda9031Posted about 2 years ago

  @hmadamk Thank you so much!

  0

  

  Ahmed Kamel•1,190

  @hmadamkPosted about 2 years ago

  @Glenda9031 anytime if you have any questions about javaScript, Html semantic, Css, accessibility feel free to ask me anything and I will be happy to give you feed back

  Marked as helpful

  1

  

  P

  Glenda Joyce Reed•1,260

  @Glenda9031Posted about 2 years ago

  @hmadamk Seriously!?! Oh man! I have a ton of questions! I hope you don't get tired of me!!!

  0

  

  P

  Glenda Joyce Reed•1,260

  @Glenda9031Posted about 2 years ago

  @hmadamk Seriously!?! Oh man! I have a ton of questions! I hope you don't get tired of me!!!

  0

  

  P

  Glenda Joyce Reed•1,260

  @Glenda9031Posted about 2 years ago

  @hmadamk Seriously!?! Oh man! I have a ton of questions! I hope you don't get tired of me!!!

  0

  

  Ahmed Kamel•1,190

  @hmadamkPosted about 2 years ago

  @Glenda9031 just throw them on me my email is [email protected]

  0
• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello Glenda Joyce, Congratulations on completing this challenge!

  I saw your preview site and I liked a lot the work you’ve done here, it's almost complete, I’ve some suggestions you can consider applying to your code:

  I saw that for some properties you’ve used rem and for others px. In this case it is better to use only one kind of unit to have a better organization for your code. relative units as rem or em that have a better fit if you want your site more accessible between different screen sizes and devices. REM and EM does not just apply to font size, but to all sizes as well.

  Save your time using a CSS RESET to remove all default settings that are annoying as the margins, paddings, decorations and optimize it making easier to work,see the article below where you can copy and paste this css code cheatsheet: https://piccalil.li/blog/a-modern-css-reset/

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  P

  Glenda Joyce Reed•1,260

  @Glenda9031Posted about 2 years ago

  @correlucas Thank you so much! I'm a new developer and was confused about when to use REM, EM, px and percentages.

  1