Equalizer Landing Page

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hello, Jean! 👋

  Great work on this challenge! Your solution looks pretty good! 😀

  Some areas that you can improve.

  • It's great that you didn't nest too much. However, I would recommend directly selecting the element that you want to style. Like this one, you can just reference the .plan-premiun instead of keep attaching the parent element, .plan .plan-premiun.
  • I would recommend using anchor tags with download attribute for the download buttons. Regardless of this, good job on specifying the type of the button elements. By doing this, you prevent the button from behaving unexpectedly.
  • For the copyright text, I would recommend making them as paragraph elements instead of a list element. It would make sense if the text is read as a normal text.

  About the media queries unit, I would highly suggest using the em unit. It has more consistent behavior across multiple browsers. There's a great blog post about which unit that you should use for media queries.

  That's it! Hope you find this useful! 😁

  Marked as helpful

  0
• 

  Akhlak Hossain Jim•1,325

  @Akhlak-Hossain-JimPosted over 2 years ago

  Great work.

  Here is my feedback,

  • where you are using .plan { ... .plan__img-bg { ... }} you can use this way .plan { ... &__img-bg { ... }}
  • in media query I think it's best to use px value rather than rem.
  • and as you are using scss try using it's own variable declearation format ie $border-dark: #000; and you can use it border: 1px solid $border-dark; so you don't have to type var() every time.

  Happy coding :)

  0