Submitted about 2 years ago
entertainment-web-app with React, TypeScript, React-routes, css-module
@Dorki-coder
Design comparison
SolutionDesign
Solution retrospective
mobile version will be soon...
Community feedback
- @JaneMorozPosted about 2 years ago
Hi, Dorki! I love your solution ❤️💪
I have noticed a few issues though:
- There is some size problem with trending section for smaller screens
- I've also noticed that scrolling doesn't work in this section as well, you may fix it by replacing
.swiper { . . overflow: hidden; . . }
with
.swiper { . . overflow-x: auto; . . }
Keep it up and good luck 🍀
0 - @AdrianoEscarabotePosted about 2 years ago
Hi Dorki, how are you?
I really liked the result of your project, but I have some tips that I think you will enjoy:
- To improve the accessibility of the project you could have put an h1. Every page must contain a level 1 header, for people who use screen readers, identity what the main title is.
- The links must have an aria-label or sr-only text that tells where the link navigates the user. For example: Visit our Facebook. For images, you should set aria-hidden=” true” to be ignored by screen readers and to avoid redundancy and repetition.
The rest is great!
I hope it helps... 👍
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord