Submitted over 3 years ago
Email validation page using HTML, CSS and JS
@NataliaKiwibird
Design comparison
SolutionDesign
Solution retrospective
It's probably not the best JS code, so any feedback regarding my JS solution will be appreciated!
Community feedback
- @A-amonPosted over 3 years ago
Hey, it'll look nicer if you put min-height:100vh to your main tag instead of body tag so that there wont be a white-space at the bottom at 800+px width.
Instead of setting styles via JS, you can add a class to the alert/info's classList to hide/show the alert/info and also for the form's changes in border.
Marked as helpful0 - @Andrii-RohovPosted over 3 years ago
You should remove overflow: hidden; because youre page not scrollable
Marked as helpful0@NataliaKiwibirdPosted over 3 years ago@Andrii-Rohov thank you for pointing this out, it's fixed now
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord