Element Alignment and Spacing

Community feedback

• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 7 months ago

  Hey @Aidanx9!

  Your solution is really impressive!

  I've got a couple of ideas (about how to use HTML better) that could make it even stronger:

  📌 First: Think about using <main> to wrap your main content instead of <div>.

  Imagine <div> and <span> in HTML as basic containers. They're good for holding stuff, but they don't tell us much about what's inside or its purpose on the webpage.

  📌 Second: Consider using <h1> for your main title instead of <h2>.

  It's more than just text size — it's about structuring your content effectively:

  • The <h1> to <h6> tags are used to define HTML headings.
  • <h1> is for the most important heading.
  • <h6> is for the least important heading.
  • Stick to just one <h1> per page – it should be the main title for the whole page.
  • And don't skip heading levels – start with <h1>, then use <h2>, and so on.

  These tweaks might not change how your page looks, but they'll make your HTML code clearer and help with SEO and accessibility.

  Hope that's helpful!

  Keep up the great work!

  1

  ---

  

  Aidanx9•10

  @Aidanx9Posted 7 months ago

  @danielmrz-dev Thanks for your advice, very kind! :)

  0
• 

  Grego•1,310

  @Grego14Posted 7 months ago

  Hello! 🎉 congratulations on completing the challenge! 🎉

  Don't skip the headings, you are using a h2 where you should use a h1.

  If you used h2 since its font size is smaller, you should not use html elements to do that type of thing, you should make the styles with CSS, it is good practice.

  Leave the alt attribute empty if the image has no semantic meaning or is for decoration!

  Remove the margin in the body element to prevent horizontal scrolling margin: 0;

  Remove the height: 497 px; in the .box-qr element so that the margin at the top of the .qr-code-info element takes effect. I recommend using min-height: 497px for this case.

  I hope this helps! 😁

  1

  ---

  

  Aidanx9•10

  @Aidanx9Posted 7 months ago

  @Grego14 Thanks for your advice, very kind! :) One thing, what do you mean with "Leave the alt attribute empty if the image has no semantic meaning or is for decoration!"? Thanks :)

  1

  

  Grego•1,310

  @Grego14Posted 7 months ago

  @Aidanx9 For example, an image that shows something that has to do with the page needs to have an alt attribute, in this case, I was wrong, you must add an alt on the image that says something like this: 'Scan the QR code to go to frontendmentor'.

  0