Design comparison
SolutionDesign
Solution retrospective
Thank you!
Community feedback
- @denieldenPosted about 2 years ago
Hello Bek, You have done a good work! 😁
Some little tips to improve your code:
- add
main
tag and wrap the main content of page for improve the Accessibility - Using
<hr>
for the line is not the best way because this tag have a semantic meaning... in this case useborder-bottom
to the header because this line is decorative - :hover effect of image not work correct and broke the design
- add
transition
on the element with hover effect - instead of using
px
use relative units of measurement likerem
-> read here
Keep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
Marked as helpful0@BekEsalyPosted about 2 years ago@denielden thanks a lot for your comment. I agree with you there are some mistakes in my code. I'm a just beginner. I appreciate your help so much.
1 - add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord