e-commerce-page

Community feedback

• 

  Matt Brannon•70

  @ghostribPosted about 2 years ago

  Hey nice work! I think it looks pretty good. A couple thoughts:

  When the mobile menu is open, tabbing through the elements closes the menu when tabbing away from the last item in the menu or tabbing backwards from the first item in the menu. Typically you want it to cycle back through the items in the menu. So it seems like your focus trap isn't quite trapping focus. I've used focus-trap-react myself and had varying degrees of success. As an alternative, you might look into @reach/dialog. The documentation is quite a bit better in my opinion and has a bunch of workable examples. Either way works though.

  Accessibility is difficult and I'm still learning a bunch about it myself. Heres's a link about accessibility in modals

  w3.org is good reference when dealing with these kinds of challenges.

  Hope that helps!

  Marked as helpful

  0