Ecommerce using Vanilla JavaScript and SCSS

Community feedback

• 

  Eles•1,300

  @eleswastakenPosted almost 3 years ago

  Everything has to be interactive or you will make some people sad :(.

  You see, when you try to navigate your page with keyboard(e.g. using tab), the only thing you can do is to leave your page because you can't order or look at the product. All this could be done using buttons and other interactive elements. So every time you think about scripting some elements, think whether that element actually is interactive; think of it this way, if you want to do something with a certain element, you probably should be using buttons or something...

  Another thing, on mobile devices when you open the menu(menu should also be a button), there is an awkward animation of the entire container sliding in. You could do it this way, make the active state of a container fade-in and the nav slide in.

  Best of luck!

  Marked as helpful

  0

  ---

  

  Christian Glenogo•130

  @CHRISTIANGLENOGOPosted almost 3 years ago

  @eleswastaken you mean every element that is clickable it should be button element right ? Will take note all your comment for the future projects. I will also make some changes for more interactive and responsive design. As of the moment I still working to make it smooth. I also look your code and I'm impressed. Will also try the same approach as yours in solving this ecommerce. I really learned something you. Thank you for your comment I appreciate it very much.

  P.s. I'll make sure that next time I will not make some people sad :)

  0
• 

  Byron•2,290

  @byronbyronPosted almost 3 years ago

  Looks like the font needs a little bit of attention in the CSS.

  @import url('https://fonts.googleapis.com/css2?family=Kumbh+Sans:wght@400;700&display=swap');
  
  body {
    font-family: "Kumbh Sans", sans-serif;
  }
  

  :thumbs_up:

  Marked as helpful

  0

  ---

  

  Christian Glenogo•130

  @CHRISTIANGLENOGOPosted almost 3 years ago

  @byronbyron I see. Thanks for that.

  0