Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

ecommerce responsive website

Tahmeedβ€’ 150

@Tahmeed-programmer

Desktop design screenshot for the E-commerce product page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
3intermediate
View challenge

Design comparison


SolutionDesign

Community feedback

Abreham Nigussieβ€’ 470

@DreamCoder7

Posted

Hello, Tahmeed!πŸ‘‹

Nice work on this challenge!πŸ‘

Here are a couple of things I'd like to suggest,

  • Using inline style for both style style.css and script script.js aren't recommended way, the reason is because of semantic markup, maintainability, reusability, and scalability. Specially on large project. check out this article it may help
  • Instead of element selector like .top-left-head ul li using class or id is more practical way

Hope that help!😊

Happy coding!😎

1

Tahmeedβ€’ 150

@Tahmeed-programmer

Posted

@redstorm-hub Thanks a lot bro for the valuable feedback. Really appreciate how you tried to share industry best practises, honestly comments like yours a gem. And to be honest this is more of a personal project which is why i sacrificed some elements regarding writing good code. But yeah i was unaware of some of the aspects you pointed out! Feel free to comment on my other projects if you wish! Once again really appreciate such a gem comment

0
Abreham Nigussieβ€’ 470

@DreamCoder7

Posted

@Tahmid-programmer

Glad you found those points helpful! Have a great day and keep coding😎

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord