Design comparison
Solution retrospective
This E-commerce Product page is my first project and I really enjoyed creating this project, however, it is still incomplete and will be completed after your feedback.
Community feedback
- @Aik-202Posted about 2 years ago
Hi Mihir, this is wonderful! Nice work! I have some suggestions tho.
-
Make sure to always put an alt text for all your images, I think that should fix most of your html and acessibility issues
-
For the ones that say you should add img src, I think the problem as to do with the way you wrote the src for the images. It ought to have been
./images/img.jg
as the images is in another folder. -
Use the
main
tag for the div with class modal as that is where your main content starts from. -
Instead of using
strike
tag, use this in your css :text-decoration: line-through
-
I also noticed that once I change the number of shoes I'm ordering, it remains unchanged in my cart.
-
Instead of using the
button
tag for your plus and minus icons, try using thediv
tag, and assigning the aria role button... i.e<div role = "button"> </div>
Hope this helps.
0@MIHI-botPosted about 2 years ago@Aik-202
Thank you so much for your suggestion. I really didn't notice much about IMG tag attributes, both src, and alt, from now I will take care of these mistakes. "line-through" CSS property and role attribute are new to me and I am really thankful for your feedback. I will surely be better in the future from this feedback.
0@MIHI-botPosted about 2 years ago@Aik-202
Thank you so much for your suggestion. I really didn't notice much about IMG tag attributes, both src, and alt, from now I will take care of these mistakes. "line-through" CSS property and role attribute are new to me and I am really thankful for your feedback. I will surely be better in the future from this feedback.
0@Aik-202Posted about 2 years ago@MIHI-bot Alright! I'm glad I was able to be of help
1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord