E-commerce product page with React

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  Hello Suleman, You have done a good work! 😁

  Some little tips to improve your code:

  • add descriptive text in the alt attribute of the images
  • to make it look as close to the design as possible add justify-content: start to the section for select number of product and add to card button
  • add transition on the element with hover effect
  • instead of using px use relative units of measurement like rem -> read here

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  1

  ---

  

  S MD suleman•3,530

  @sulemaan7070Posted almost 2 years ago

  @denielden working on that buddy.. thank you

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  @sulemaan7070 you are welcome and keep it up :)

  0
• 

  Jamal•120

  @JamalLovesLoversPosted almost 2 years ago

  Hey awesome job looks like you have given it a solid go. Firstly, its pretty obvious right away that this website does not match the design given by frontend mentor which sometimes is a good thing but in this case there is way too much customization. The size of buttons icons, pictures is far too big and doesn't fit on the screen properly. Capitilisation is also an issue as stuff like 'cart' and 'fall' are not capitalised. For mobile I read that you didn't focus much on it but seems like the whole add to cart button is missing which is not good. The navbar is also rather large especially those icons, they are noticible of the bat. When the cart is empty the content looks strange, perhaps centering the no items in cart will help. Also spacing stuff out will too. When an image is clicked reduce the opacity and add a border on the thumbnail so it is apparant which one is clicked.

  Positives

  The function of the website is fantastic, I love that you can't add item to cart if it as 0 great addition. Also seems like while still on ipad level dimensions the website works great.

  Feel free to mark this as helpful and ask for any questions i was unclear

  1

  ---

  

  S MD suleman•3,530

  @sulemaan7070Posted almost 2 years ago

  @JamalLovesLovers .. hey jamal thank you pointing the flaws.. i really have to work the mobile version.. by the way as you mentioned the about the add to cart button. It is visible. Thank you

  0

  

  Jamal•120

  @JamalLovesLoversPosted almost 2 years ago

  @sulemaan7070 Sorry about that, seems like some sort of caching issue, I was refferring to the checkout button which for some odd reason was not loading

  0