E-commerce product page using React, Typescript, Mobx and Sass

Community feedback

• 

  Sahand Masoleh•1,210

  @sahand-masolehPosted about 2 years ago

  Hey there!

  I just completed the same challenge! Your solution is very nice, I wasn't expecting strong competition so soon. :D

  Here's a few things I noticed:

  • The lightbox modal doesn't cover the page all the way to the bottom, it kind of gives the feeling that some information is supposed to be there.
  • For the borders around the thumbnails, I suggest using outline instead of border to avoid shifting the element, if that's unintended.
  • If you open the lightbox modal while the cart is open, the cart says on top of the lightbox. Should be an easy fix with z-index.

  Marked as helpful

  1

  ---

  

  Eugenia•950

  @JaneMorozPosted about 2 years ago

  Hi @sahand-masoleh!

  I haven't noticed this z-index problem 🙀. I'll look into it and other things. The lightbox modal was kinda tough.

  Thank you!

  1

  

  Sahand Masoleh•1,210

  @sahand-masolehPosted about 2 years ago

  @JaneMoroz No problem!

  For modals you can use the built-in portals of React to make your life easier.

  Marked as helpful

  2