Ecommerce Product Page using CSS and Vanilla JS

Community feedback

• 

  Ivan•2,630

  @isprutfromuaPosted over 2 years ago

  Hi there. You did a good job 😎

  keep improving your programming skills🛠️

  your solution looks great, however, if you want to improve it, you can follow these recommendation:

  ✅ Use a CSS reset . By default, browsers don’t apply the same default styling to HTML elements, a CSS reset will ensure that all element have no particular style. For example: css-reset

  ✅ Write consistent CSS. At the beginning part of the project you can set some rules for maintain throughout to your entire stylesheet. If you follow the convention or BEM, you’ll be able to write CSS without being afraid of side effects.

  ✅ Use rem’s or em’s. Using rem’s or em’s is more dynamic way instead of using pixels. Try to use rem’s or em’s rather than pixels.

  ✅ Don’t use @import . The @import directive is much slower than the other way to include stylesheets into a html document:

  <link rel='stylesheet' type='text/css' href='a.css'>
  <link rel='stylesheet' type='text/css' href='font.css'>
  

  ✅ Avoid Extra Selectors. Adding extra selectors won't bring Armageddon or anything of the sort, but they do keep your CSS from being as simple and clean as possible.

  ✅ Use Clamp . The clamp function make smaller and simple CSS to control element width.

  width: clamp(100px, 50%, 300px);
  

  ✅ Use CSS Variables . Making the code flexible is equally important so that refactoring won’t be a problem for you. One of the best ways to achieve this is variables.

  I hope my feedback will be helpful. You can mark it as useful if so 👍 it is not difficult for you, but I understand that my efforts have been appreciated

  Good luck and fun coding 🤝⌨️

  Marked as helpful

  1

  ---

  

  Mofe•440

  @Mofe620Posted over 2 years ago

  @isprutfromua Wow. Thanks a whole lot. It's going to take some time to apply all these stuff but I'll keep trying. I'm grateful for this. Wish you even more success in your journey 😊

  0

  

  Ivan•2,630

  @isprutfromuaPosted over 2 years ago

  @Mofe620 thank you a lot.

  Contact me if you have any questions

  Cheers

  1