Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

E-Commerce Product Page created using React and Sass/SCSS

P

@Lorand98

Desktop design screenshot for the E-commerce product page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
3intermediate
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello :) Could you please give me some feedback regarding my project? I feel that the code is not optimized and there are tons of places where I can improve my code. For example, in the components > Article > ArticlePhotos components, I'm changing the photo using the selectPhotoHandler function and I feel like it's very slow when doing the first few switches/selections (it's reacting slowly). Could you please confirm what could be the reason for this? Is there any more optimal way to switch more fluently between the photos?

Also, could someone please check my sass file structure? I'm keeping everything general (mixins, variables, colors, etc...) under the sass folder and I'm keeping the component-specific styles in CSS modules, in the same folder as the components, for example, Article.jsx -> Article.module.scss. Is my sass development mode alright? Also, should I better keep my color-related variables in the colors.scss file? Or is this ok the way I did?

Your feedbacks are very welcome! :)

Thank you and best regards, Lori

Community feedback

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord