E-Commerce with React, useContext, useReducer and localstorage

Community feedback

• 

  Evan Parker•200

  @evancp87Posted almost 2 years ago

  Things i'd appreciate feedback on:

  -Making the open cart responsive when absolutely positioned was slightly painful, surely there's a better way?

  -I wasn't sure if i implemented the overlay in a DRY fashion.

  -on that note, i think the lightbox could've done with splitting out, and resused quite a bit of code that could of been simplified. I found it a challenge to reuse a lot of the components, or more i'm not sure if i did it in the best way

  0

  ---

  

  Zeyad Mohamed•320

  @ZeyadMohamed1805Posted almost 2 years ago

  Your website is really cool! I do have some tips to share with you:

  1. Make sure that you apply the font-weights to your paragraphs. They would also look better if they had more space between them. You can quickly fix that by adding line-height: 1.5rem; to the paragraphs' css.
  2. You might consider slightly increasing the font-size of the Sneaker Company header.
  3. The size of the image on the mobile version is too large. I suggest you set its max-width to like 500px and center it.
  4. About making the cart responsive, you can try to set its width to like 90% and position it in the center of the page.

  Overall, everything is fantastic on your website! I really hope this feedback will help a little. Please check out my solutions and react to them / comment to me on how to improve them. It really helps!

  Marked as helpful

  1

  

  Evan Parker•200

  @evancp87Posted almost 2 years ago

  @ZeyadMohamed1805 Thanks Zeyad, your advice is much appreciated and very helpful!

  1