React js, react icons, react modal

Community feedback

• 

  yishak abrham•2,150

  @yishak621Posted almost 2 years ago

  Hey there ...congrats for completing the challenge but fix these .....the side-bar should be fixed position and also the z-index must be greater than 1 ....i see ur design in Mobile so these comment is for Mobile version ...the top margin of navbar should be minimized ...the functionality of the gallery is not working i press the prev and next btn and nothing happened ...so create some kind of local data array and add a functionality to the gallery ...the notification number position is a little bit off fix that too ..happy coding ☺️

  1

  ---

  

  Celso Tavares•110

  @CelsoTavaresPosted almost 2 years ago

  @yishak621 Thanks for the tips, I made some changes to the code.

  0
• 

  Nikola D•1,510

  @NikolaD93Posted almost 2 years ago

  Looks nice bro, well done! Here are some suggestions:

  1. Try not to use DOM selectors in React
  2. Instead of using IF-ELSE for image slider try to do it with useState hook. Good luck with next challenges!

  1

  ---

  

  Celso Tavares•110

  @CelsoTavaresPosted almost 2 years ago

  @Nikola1232456 Thanks for the tips, I made some changes to the code.

  1