Ecercise_4_nft_card_component with SASS and a lot of love

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello @fedementre, Congratulations on completing this challenge!

  Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:

  1.Add transitions to make the interaction smoother while the element gets hovered, you can use a value like transition: all ease-in 0.5s.

  2.Use units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices.

  To save your time you can code your whole page using px and then in the end use a VsCode plugin called px to rem here's the link → https://marketplace.visualstudio.com/items?itemName=sainoba.px-to-rem to do the automatic conversion or use this website https://pixelsconverter.com/px-to-rem

  3.Use a CSS reset to avoid all the problems you can have with the default CSS setup, removing all margins, and making the images easier to work, see the article below where you can copy and paste this CSS code cheatsheet: https://piccalil.li/blog/a-modern-css-reset/

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  Federico Durante•70

  @fedementrePosted about 2 years ago

  @correlucas Wow! These tips are explosive! transition: all ease-in 0.5s; makes everything smoother and interesing. Instead the px to rem conversion plug-in I tried it and it's amazing! Thanks also for the CSS reset code, it's valuable material <3 love you! What do you think my problem related to icon-view position doing zoom-in and zoom-out with ctrl + is due to? Do you have any solutions? Meanwhile thank you very much and I hope you can give me more tips in the future! <3

  0

  

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  @fedementre Hey Fedementre, I'm happy to hear that. I think I guess what happened with the zoom

  Try to use:

  .img_container:hover .hover_bg_container:after {
      content: url(images/icon-view.svg);
      position: absolute;
      top: 0;
      right: 0;
      bottom: 0;
      left: 0;
      /* transform: translate(-50%, -50%); */
  }
  

  And the position relative in the img box

  👨‍💻Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/nft-preview-card-vanilla-css-custom-design-and-hover-effects-b8D1k9PDmX

  Marked as helpful

  0

  

  Federico Durante•70

  @fedementrePosted about 2 years ago

  @correlucas Unfortunately, this is not the solution but I thank you for trying! <3

  1