Skip to content
Submitted over 3 years ago

easybank-landing-page-master

NoorAlhijab•385
@NoorAlhijab
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Easybank landing page
  • HTML
  • CSS
  • JS
3intermediate

Design comparison

SolutionDesign

Solution retrospective

I just finished this challenge and was so great to refresh my coding skill because I stopped coding for about three months and I am so excited to come back and test myself with this challenge. Any feedback to improve my skill is appreciated.

Community feedback

  • Devisetti Teja•530
    @Teja54Posted over 3 years ago

    This comment was deleted over 3 years ago

    1
    NoorAlhijab•385
    @NoorAlhijabPosted over 3 years ago

    @Teja54 Thank you for that compliment!

    0
  • Raymart Pamplona•16,100
    @pikapikamartPosted over 3 years ago

    Hey, great work on completing this challenge. The layout in desktop is good as well in mobile.

    Upon resizing, I see that your navbar items gets stretched out. To prevent those, you can add align-items: center or align-items: flex-start on your .nav-flex selector. This will make sure that the items don't get stretched out , like it is doing now when resizing the browser.

    Also, it seems that your first image in the article sections, is a lot bigger compared to those other three, you might want to check that one out for consistency.

    Lastly, it would be really great to make some adjustment in the layout of the why choose easybank and the articles. Because as I resizes, going in mobile state, they are squished and gets very narrow. So I think it will be a great idea to dedicate some different layout on those when they start to seem different when the browser is resized.

    But still, overall, you did an awesome solution^

    0
    NoorAlhijab•385
    @NoorAlhijabPosted over 3 years ago

    @pikamart
    I'm going to make these changes. Thank you for your feedback.

    0
    NoorAlhijab•385
    @NoorAlhijabPosted over 3 years ago

    @pikamart I completed modifying the website. Could you please check my updates? Thank you!

    0
    Raymart Pamplona•16,100
    @pikapikamartPosted over 3 years ago

    @NoorAlhijab Awesome, now those issues are gone and the layout is really really good and that custom grid layout in the article and why choose is awesome as well.

    The navbar did not resize again like the last time and is good looking

    Thank you for having the time to check and address those issues, and thank you as well for following my suggestions^^

    0
    NoorAlhijab•385
    @NoorAlhijabPosted over 3 years ago

    @pikamart Thank you for your time and support!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord