Janelle Schuh• 90
@jschuh23
Posted
@kaiohnr The site looks awesome!!
I did notice that there are a number of accessibility issues per the Frontend Mentor checks.
- Document should have one main landmark: This can be solved by adding a
main
element which completely surrounds everything between yourheader
andfooter
. - All page content should be contained by landmarks: I suspect that when you add the
main
element then this error will go away (?). - Links must have discernible text: My suggestion would be to add either
alt
text such as "Twitter logo" or anaria-label
. Then a screenreader would have something to read.
Regarding the hover color for the social icons....because those are images you cannot use the fill
property. That is only for SVGs. So you can either change your icons to SVGs or do something different for your hover.
Hope this helps :)
Marked as helpful
1