Easybank Landpage

Community feedback

• 

  Janelle Schuh•90

  @jschuh23Posted over 2 years ago

  @kaiohnr The site looks awesome!!

  I did notice that there are a number of accessibility issues per the Frontend Mentor checks.

  • Document should have one main landmark: This can be solved by adding a main element which completely surrounds everything between your header and footer.
  • All page content should be contained by landmarks: I suspect that when you add the main element then this error will go away (?).
  • Links must have discernible text: My suggestion would be to add either alt text such as "Twitter logo" or an aria-label. Then a screenreader would have something to read.

  Regarding the hover color for the social icons....because those are images you cannot use the fill property. That is only for SVGs. So you can either change your icons to SVGs or do something different for your hover.

  Hope this helps :)

  Marked as helpful

  1

  ---

  

  Kaio•460

  @kaiohnrPosted over 2 years ago

  @jschuh23 Thanks! I'll try to solve the problems and try to change the icons for others that I can change the color!

  0

  

  Kaio•460

  @kaiohnrPosted over 2 years ago

  @jschuh23 Thanks! I'll try to solve the problems and try to change the icons for others that I can change the color!

  0