@TedJenkler
Posted
Hi @AchinthyaDulshan,
Nice project! I especially liked the animation on the navbar—great job on that!
I have a few tips for improvement. I noticed that you have your components folder inside the assets folder. Typically, the assets folder is used for design-related items like images and sometimes SCSS files. It’s usually better to place the components folder alongside the assets folder in the src directory. This would make your project structure easier to navigate and understand.
Also, if you’re using the <img /> tag for SVGs, keep in mind that you can’t use the inline fill attribute—it only works with the <svg /> tag. If you prefer using <img /> tags for SVGs (which isn’t recommended), you’ll need to override the fill with CSS. When using the <svg /> tag, be sure not to include the fill attribute in the path element, as it would override any Tailwind CSS classes you apply.
Otherwise, this project is solid and responsive, and you’re using a good structure.
I hope this feedback is helpful!
Best, Teodor
Marked as helpful
@AchinthyaDulshan
Posted
Hi @TedJenkler
I greatly value your feedback on my project. Your insights on the component folder and the SVG tag were very enlightening. I will incorporate this knowledge to enhance my next project significantly.
Thank you, Achinthya.
