Easybank landing page - using HTML, SCSS, JavaScript

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted about 3 years ago

  Greetings Soe

  • the design is pretty good on all sizes that i checked .Well done
  • <img src="/images/image-currency.jpg" alt="EasyBank"> , so as an example if i am an assistive technology user and the word Easybank is read to me , what message do i get. My point is , let your alt value be descriptive for the benefit of assistive technology users to be able to visualize the message that is being put across. Decorative messages should have an empty alt value alt=""
  • Can this be a link to another page?

  <a href="#" id="btnHamburger" class="header__hamburger hide-for-desktop">
          <span></span><span></span><span></span>
        </a>
  

  in my opinion this is meant to open the nav list , hence a button would be appropriate

  • For the nav list , use an unordered list - it is beneficial to assistive tech users as information such as the length of the list and the current tab position will be announced by each tab

  <div class="header__menu has_fade">
  // use an unordered list
        <a href="#">Home</a>
        <a href="#">About</a>
        <a href="#">Contact</a>
        <a href="#">Blog</a>
        <a href="#">Careers</a>
      </div>
  

  Happy coding

  Marked as helpful

  1

  ---

  

  Soe Arkar Htet•245

  @SArkar-HtetPosted about 3 years ago

  @ChamuMutezva I'm not quite sure I understood you correctly. Did you mean how to use alt value or alt="Easybank" should use in logo, main image and icons? However, some decorative message (like articles image in my live site) should have an empty alt value. Am I correct? Sorry for my bad english.

  0

  

  T

  Chamu•13,130

  @ChamuMutezvaPosted about 3 years ago

  @SArkar-Htet, Easybank is not descptive enough, you are not telling the user that there is an image (the screen readers does that automatically). The content of the image is what you should write in the alt. If the logo is decorative then just use alt=""

  • if the logo is important, I will try something like Welcome to Easybank, your one stop financial institution
  • Some of the images can have an alt=""
  • <img src="/images/image-currency.jpg" , I would write an alt like, any currency in the world you want, we have it or leave it empty. It all comes to you on what you see in the image

  Marked as helpful

  0

  

  Soe Arkar Htet•245

  @SArkar-HtetPosted about 3 years ago

  @ChamuMutezva thanks for your feedback. It is very valuable for me.

  0
• 

  Hafizan Adli•1,190

  @hafizanadliPosted about 3 years ago

  Great work, all component is responsive in every screen! No worry with font size too Keep up the good work!

  0

  ---

  

  Soe Arkar Htet•245

  @SArkar-HtetPosted about 3 years ago

  @hafizanadli Thanks bro

  0