Responsive easybank landing page using SASS&BEM

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 2 years ago

  Hi, katrine9176! 👋

  Nice work on this challenge! 🙌 Your solution looks good and is responsive! 👍

  Just a few small tips for you! 🙂

  You don't need to add aria-hidden="true" to images if you leave their alt attribute empty (since that will already cause screen readers to ignore those images).

  To make your HTML a little more semantic, you can use ul and li elements to wrap the list of features in the "Why choose Easybank?" section (you can do the same thing for the list of links in the footer of the page). 😉

  It would be worth adding some aria-labels to the social media links in the footer of the page since they don't have any text inside to identify them.

  And lastly, try to use only one h1 tag per page. This is a good practice since there should be only one most important heading on a page. You can use less-important headings tags (such as h2 and h3) for the rest of the headings on the page.

  Hope you find this helpful. 😊

  Keep coding (and happy coding, too)! 😁

  Marked as helpful

  0

  ---

  

  katrine9176•540

  @katrine9176Posted almost 2 years ago

  @ApplePieGiraffe really really thank you for your feedback! Btw, I added two h1 tags by accident and I've just fixed it.

  1