Easybank landing page master - CSS Grid

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted over 3 years ago

  Hey, great work on this one. The layout in desktop is good and the mobile state as well.

  Some suggestions would be:

  1. Please refrain from using vh units in height okay. Setting that limits your content's height, based on the screen of the user, height of the screen to be exact, so it differs right and if a user have lower in terms of height, they will get this overlapping contents. Try inspecting your layout in dev tools from the bottom, your intro selector size goes smaller, because you use vh on the height. Instead of that, use rem which is a lot better, or just let the content create the dimension of the container. But please refrain from using height: vh in another solutions okay.

  2. It will be awesome to implement hamburger menu using button. Since buttons have a natural focus, when users who uses screen readers, they will be easily redirected and know when they are in the hamburger menu.

  Only those two. But that height is really destroying the layout so it is important for you to check that one out.

  But still, good job on this^

  1

  ---

  

  Fajar Hidayat•165

  @fajarhidayattPosted over 3 years ago

  Hey @pikamart. Thank you for the feedback you provide. Regarding the use of the vh unit for height in the intro section, I didn't think that one bit of a bad thing would happen, it's my fault. I was so focused on beautifying my own screen that I forgot to pay attention to other users' screens. And btw I spent a lot of time setting up the intro section, lol.

  And to use the button on the hamburger menu I didn't think of it, maybe for the next work I will implement this. And thanks for the feedback, in the next time I will fix this error.

  0