Easybank landing page

Community feedback

• 

  P

  Fluffy Kas•7,715

  @FluffyKasPosted over 2 years ago

  Hiya,

  It looks really nice, well done! I only have a few small suggestions for you:

  1. Instead of giving an alt text to the mobile menu button's image, I'd perhaps hide the image itself and add the same text as an aria-label to the button.

  2. The card <div>s inside the article section could be swapped with <article>. It's also perhaps not the best if the alt text of those article images are just repeating the article's title, it causes repetition if a screen reader reads them out. I think they're mostly just decorative images, so you may as well add an aria-hidden="true" to these too.

  3. I'm not sure object is the best solution for the social media links. I never used an object element before, but it might be a completely valid solution (although an img wrapped in <a> seems easier). It still needs to have some sort of text description because not everyone can see the images ^^

  4. A short transition on the buttons and links would look nice!

  1

  ---

  

  Lucas Fernando•760

  @lucasfernandodevPosted over 2 years ago

  @FluffyKas Thank you very much for the feedback

  0
• 

  MOHAMAD NAZIR MD NAZRI•180

  @NAZIRwill29Posted over 2 years ago

  Hi @lucasfernandodev

  It was really great website. How do you make the hover effect for the menu-link? Do you make it change the menu-link::after?

  I just have one suggestion for you:

  • better add animation: transition for navigation after and before the click event so it will make the smooth transition.

  0

  ---

  

  Lucas Fernando•760

  @lucasfernandodevPosted over 2 years ago

  @NAZIRwill29 Thanks for the feedback, the .menu-item:hover effect and a width animation on the menu-link::after pseudo-element.

  0