E Commerce Product Page Using Sass and jQuery

Community feedback

• 

  Fraser Watt•1,790

  @fraserwatPosted almost 3 years ago

  Hey, this is looking great!

  Few things I'd change:

  • Look into only needing a single <nav> component, and switching between it being a hamburger menu and an always-visible header menu depending on your media query. Here's a walkthrough https://dev.to/devggaurav/let-s-build-a-responsive-navbar-and-hamburger-menu-using-html-css-and-javascript-4gci
  • Instead of using height and width attributes, use max-width on your top-level container, and let everything else fill the screen responsively. Might need to play around with padding and margins a bit, but it will give you more flexibility, and you'll be able to build more responsive web pages.
  • The above will also make it easier to have more consistent design margins - e.g. the left and right edges of the heading don't line up with the left and right edges of your <main> component.

  Aside from that, great stuff - keep it up!!

  Fraser

  Marked as helpful

  0

  ---

  

  Luke Fernando•130

  @Luke-FernandoPosted almost 3 years ago

  @fraserwat Thank you very much for this very detailed review. This will help me a lot to improve myself. I will definitely update my code soon again.

  0