E-commerce product page

Community feedback

• 

  P

  Srijan Manandhar•470

  @srijanssPosted 3 months ago

  • The solution includes semantic HTML
  • Solution is not fully accessible using keyboard, you can enable outline on a, button tags so that keyboard users knows about the active element on the page
  • also it would be helpful for screen readers users by adding different aria attributes to define different states in the app e.g popup open/close , add to cart success etc.
  • Layout looks good on all screen sizes
  • Code is readable, but it can be structured into smaller components for reuse
  • Solution differs a bit from the design, the lightbox component is not working
  • I liked how you've used animations in menu and slider library for the image gallery

  Marked as helpful

  0