Dynamic Time Tracking Dashboard - Built w/ Codux (React and TS)

Community feedback

• 

  maia•300

  @maiaflowPosted over 1 year ago

  impressive, Eric! i have very little understanding of what Codux, React, IDE, TypeScript are, but that makes this all the more impressive! that H accessibility one has gotten me in the past, definitely interesting that they want you to go in order. well done as always!

  Marked as helpful

  1

  ---

  

  Eric Salvi•1,350

  @ericsalviPosted over 1 year ago

  @maiaflow I actually realized what I did wrong.

  In my hour cards I had the top category title set as an h3 and the actual large hour set as an h2. That makes sense with the order I had in the warnings. So it was easily fixed by swapping the header levels.

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which causes lacking of landmark for a webpage

  ---

  • So fix it by replacing the <div id="root"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Eric Salvi•1,350

  @ericsalviPosted over 1 year ago

  Thank you @0xAbdulKhalid

  Codux is a newer program that is also new to me. It has limitations that I was not able to find when constructing this project. It has a built-in library of common HTML components so I'll need to check to see if it has the option to add semantic ones and not the div or span ones.

  I did start going back in assigning roles instead but have yet to generate a new report.

  I'll go in and check to see if I can update the main div to a main and fingers crossed that things won't break.

  Thanks again.

  0

  

  Eric Salvi•1,350

  @ericsalviPosted over 1 year ago

  @0xAbdulKhalid

  All fixed. Thanks for that insight. Just replacing the main div for the App ID to <main> fixed a bunch.

  Also in my Chromes Axe Dev Tools, I realized I didn't have best practices so It didn't show those warnings before I submitted.

  0