Dynamic Advice Generator with ReactJS + Typescript + API

Community feedback

• 

  Marzuk Sanni•1,360

  @ZukizukPosted 10 months ago

  Hello there, Congratulations on completing this project

  Your solution looks nice

  I have few suggestions that I think might be of interest to you.

  - HTML: Consider using semantic HTML tags like <main></main>,<section></section> and others that you can find in this link. And in this case, replace the <div> with role="main" for <main>. The main tag should hold the main content of the page so consider correcting that. And since there's a semantic element for the main role why use a div and give it a role of main?

  The semantic HTML tags help the search engines and other user devices to determine the importance and context of web pages. The pages made with semantic elements are much easier to read. It has greater accessibility. It offers a better user experience. Using div when there's a better alternative is not a good practice as div hold no semantic value.

  - Heading The heading elements are H1, H2, H3, H4, H5, and H6 with H1 being the highest (or most important) level and H6 the least. you can't skip them. If you haven't used h1 already you don't use h2 h3 and so on.

  I hope this feedback is helpful

  Other than that great job

  0