Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

dropdown menus using js

Jouter 90

@Joutee

Desktop design screenshot for the Intro section with dropdown navigation coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


I struggled a little bit with dropdowns because its the first time making them. I'm almost sure that I didn't do it in the best or common way, so any advice welcomed.

Community feedback

Roksolana 910

@RoksolanaVeres

Posted

Hi! From what I see, you did well with the drop-downs. I have noticed some minor issues with the main image and the hamburger menu, which are easy to fix.

The problem with the image is that on screens larger than 800px when we shrink the screen, the image doesn't shrink proportionally but is cut off on the right side. To make it look better you should set width:100% (instead of 550px) to .mainImage.

As for the menu on small screens, I suppose that together with the overlay it should stretch from top to bottom of the page (not only have height:100vh). To achieve this you can set the following properties to corresponding elements:

  1. body{ height:100%; position: relative}

  2. .overlay {height: 100%;}

  3. @media (max-width: 800px) .topBar { height: 100%}

Sorry for my ugly markup, I haven’t learned how to write code examples properly here yet 😔

1
DrZero1234 210

@DrZero1234

Posted

Hey!

I think the dropdown works and looks as its intended but I cant really tell if you could´ve implemented it better because the code is not up in GitHub. There is an obivous issues however the fact that the user cant open these dropdowns because the hamburger menu / sidebar has not been implemented yet (at least i cant see it).

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord