Don't mind me, just getting started

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 📄:

  • The <figure> tag should be used only when captions are required with <figcaption>. In this challenge, it is not required.

  Alt text 📷:

  • The alt attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.

  • The alt attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a better alt attribute would be QR code to frontendmentor.io

    If you want to learn more about the alt attribute, you can read this article. 📘.

  CSS 🎨:

  • Setting the font-size to 62.5% can attract compatibility issues with third-party libraries or plugins. You can read more about this with this lectures:

    • 1. Should I change the default HTML font-size to 62.5%?.
    • 2. The Surprising Truth About Pixels and Accessibility - The 62.5% trick.
    • 3. A comment on the 62.5% trick

    Credit to grace-snow and vanzasetia for pointing this out.

  • Avoid repeating __ if you are using BEM naming convention because only one block name is allowed, For example, the class name app_qrcode__box__img_wrapper__img contains the block name app_qrcode and app_qrcode__box. Instead, you can use app-qrcode__image.

    You can see an example of this error here: BEM Quick start - Nesting

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  1

  ---

  

  Pipow•500

  @PipouwPieuwPosted almost 2 years ago

  @MelvinAguilar Thank you so much for the feedback! I'll look into it and will try to improve my code accordingly :)

  0
• 

  Pipow•500

  @PipouwPieuwPosted almost 2 years ago

  I updated the page after making some fixes as suggested by @MelvinAguilar. This was really helpful, thank you again! 😄

  I also noticed there seem to be a box-shadow around the white block but as there's no way to retrieve its exact properties from the png I'll let it aside.

  0