Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Div's, css and many attempts

@Playerrl-ux

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

T
Grace 30,650

@grace-snow

Posted

This is being cut off on some screen sizes, so I can't scroll up to access the rest of the image. The cause is setting html and body height to 100%. Remove all of that. Generally you don't need to touch styling on HTML.

Instead, to center the component on the screen, give min-height: 100svh to the flex column container (or better yet, move all of those styles to the body!).

I have reviewed this challenge a lot and you've got most of the same mistakes most people make. So rather than repeat them all again here, I'll point you to feedback I already left on someone else's solution: https://www.frontendmentor.io/solutions/qr-code--component-nv34-WBzOO.

See if you can refactor your solution applying all the learnings from that. Then if there is anything left I'll happily look at yours again.

Good luck.

p.s. FYI @LunaHeuguerot in case you're also interested to read it.

0

@LunaHeuguerot

Posted

I'll fix the media queries width using max-width and %, other than that and the font I think it's great.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord