@DylandeBruijn
Posted
Hi Briskett,
Completing something you have been struggling with is definitely a good thing! You can be proud of your solution because it is very close to the design specifications. You have a great mindset, keep that up!
I think the requirement for 1140px is just so your solution looks good on desktop and above. In this case it doesn't matter that much because the QR code is centered anyway.
I would be happy to help with any specific CSS questions if you want. A lot of people underestimate the language and struggle with it, and it's a lot of work to be great at it.
A bit of friendly constructive advise:
-
You could try to make your CSS more reusable by using CSS variables.
-
It's good practice to use descriptive (reusable) CSS classes. You could name your container
.qr-code-cardfor example. And your image.qr-code-imagefollowing the same principle. This helps you and other developers make sense of your code. It also helps you style things as you know better what you are actually styling! I like to view elements on a page as components and style them that way. A CSS naming convention can help with that, but that's a personal preference. -
I see you used a inline style block to style your HTML elements. While this has it's uses it's generally good practice to create a separate CSS file and link this in your HTML file like this:
<head>
<link rel="stylesheet" href="style.css">
</head>
I hope you find my feedback helpful and let me know if you have any other questions!
Marked as helpful
@briskett
Posted
@DylandeBruijn Thank you, I will be sure to look into the naming convention.
