display grid, display flex

Community feedback

• 

  Brandon Alobwede•470

  @BrandaoAPosted over 1 year ago

  you did a great job there carrying out this excercise. but i think i have a little suggestion to add as your card doesn't really appear at the center of the page.

  TO CENTRALIZE CARD body { min-height: 100vh; display: grid; place-items: center; }

  i think this code would help you centralisze your work instead of using a height 100vh and max-width 1400px. please let it know if it works out too

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  BACKGROUND iMAGE 📸:

  • Looks like the background images has not been properly set yet, they are slightly misplaced. So let me share my css snippet which helps you to easily apply the background color with the background svg they provided to place perfectly as same as design.

  ---

  • Add the following style rule to your css, after completing these steps you can experience the changes.

  body {
  background: url(./images/bg-pattern-top.svg), url(./images/bg-pattern-bottom.svg);
  background-position: right 52vw bottom 35vh, left 48vw top 52vh;
  background-repeat: no-repeat, no-repeat;
  background-color: hsl(185deg, 75%, 39%);
  }
  

  • Tip, Don't forget to generate a new screenshot after editing the css file

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0