Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

display flex solution

Anthony Richardโ€ข 70

@R-clout

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

i dont know how i did... im still on javascript decided to come back to html and css then see how it goes.. i hope i did well with this.. id love criticism thhank you for your time.

Community feedback

Daniel ๐Ÿ›ธโ€ข 44,230

@danielmrz-dev

Posted

Hello there!

Congrats on completing the challenge! โœ…

Your project looks great!

I have a suggestion about your code that might interest you:

๐Ÿ“Œ You can use the <picture> tag when you have different versions of the same image.

Using the <picture> tag will help load the correct image to the user's device, saving bandwidth and improving performance.

Example:

<picture>
    <source media="(min-width: 768px)" srcset="{desktop image path here}">
    <img src="{mobile image path here}" alt="{alternative text here}">
</picture>

I hope this helps!

Other than that, excellent work!

Marked as helpful

0

Anthony Richardโ€ข 70

@R-clout

Posted

Thank you so much for taking your time. i appreciate it so much@danielmrz-dev

1
P
Koda๐Ÿ‘นโ€ข 3,810

@kodan96

Posted

hi there! ๐Ÿ‘‹๐Ÿ‘‹

The reason why your content is not centered without fixed margin is because you didn't specify min-height: 100vh; on your body. If you add this to the body element in CSS your content should be centered by default and you can remove the margins from your @media queries.

Other than that it looks pretty nice, keep up the good work! Hope this was helpful, Good luck and happy coding!

Marked as helpful

0

Anthony Richardโ€ข 70

@R-clout

Posted

thank you so much for taking your time. i promise to work better learning more about it. Enjoy the rest of your evening@kodan96

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord