display flex solution

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 7 months ago

  Hello there!

  Congrats on completing the challenge! ✅

  Your project looks great!

  I have a suggestion about your code that might interest you:

  📌 You can use the <picture> tag when you have different versions of the same image.

  Using the <picture> tag will help load the correct image to the user's device, saving bandwidth and improving performance.

  Example:

  <picture>
      <source media="(min-width: 768px)" srcset="{desktop image path here}">
      <img src="{mobile image path here}" alt="{alternative text here}">
  </picture>
  

  I hope this helps!

  Other than that, excellent work!

  Marked as helpful

  0

  ---

  

  Anthony Richard•70

  @R-cloutPosted 7 months ago

  Thank you so much for taking your time. i appreciate it so much@danielmrz-dev

  1
• 

  P

  Koda👹•3,830

  @kodan96Posted 7 months ago

  hi there! 👋👋

  The reason why your content is not centered without fixed margin is because you didn't specify min-height: 100vh; on your body. If you add this to the body element in CSS your content should be centered by default and you can remove the margins from your @media queries.

  Other than that it looks pretty nice, keep up the good work! Hope this was helpful, Good luck and happy coding!

  Marked as helpful

  0

  ---

  

  Anthony Richard•70

  @R-cloutPosted 7 months ago

  thank you so much for taking your time. i promise to work better learning more about it. Enjoy the rest of your evening@kodan96

  1