Display Flex, Grid and Media Queries

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey @SirMeierLink, some suggestions to improve you code:

  • Implement a Mobile First approach 📱 > 🖥

  With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.

  • The Alt Tag description in the logo needs to be improved upon. The logo is arguably the most important image in you page. So the description should state the company name.

  • The headings are being used incorrectly. There can only be one <h1> Heading per page. Once the <h1> Heading has be used, you will use the next heading level and so on; depending on the headings' level of importance.

  • The Illustrations serve no other purpose than to be decorative; They add no value. Their Alt Tag should left blank and have an aria-hidden=“true” to hides it from assistive technology.

  • The phone and email on the footer should be wrapped in Anchor Tags and set the href in the following manner so users can click on them and the phone/email app can open automatically:

  Phone:

   <a href="tel:+1-543-123-4567">Phone: +1-543-123-4567</a>
  

  Email:

   <a href="mailto:[email protected]">[email protected]</a>
  

  Happy Coding! 👻🎃

  Marked as helpful

  1

  ---

  

  Adrian•550

  @SirMeierLinkPosted about 2 years ago

  @vcarames Thank you for the helpful tips, especially using anchor tags for the phone and email.

  0