Skip to content
Submitted about 2 years ago

display: block;

Camilo V. Murt Tamayo•180
@zousk-Camilo
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hello World!!!

Community feedback

  • Lucas 👾•104,400
    @correlucasPosted about 2 years ago

    👾Hello Camilo, Congratulations on completing this challenge!

    Here's some tips for you:

    Something I've noticed in your code is that in many occasions you've added some <div> to wrap contents that don't really need to be inside of a div block. Note that for this challenge all you need is a single block to hold all the content, can be <div> or <main> if you want to use a semantic tag to wrap the content, the cleanest structure for this challenge is made by a block of content with div/main and all the content inside of it (img, h1 and p) without need of any other div or something. See the structure below:

    <body>
<main>
<img src="./images/image-qr-code.png" alt="Qr Code Image" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

    Use units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices.

    To save your time you can code you whole page using px and then in the end use a VsCode plugin called px to rem to do the automatic conversion or use this website https://pixelsconverter.com/px-to-rem

    ✌️ I hope this helps you and happy coding!

    0
  • Samuel M. Setiawan•200
    @samuelms21Posted about 2 years ago

    Hello there, good job on this one. You are at 90% of your progress to match this project with the desired design. Just one tiny improvement, you can increase the font-size and change the color for the card heading. To match the style guide, change the color to hsl(218, 44%, 22%), which is dark blue.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord