Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Display and position properties

K.N8baron 20

@kawthar-tor

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Please check my code , see if there's any technique to learn and make the task easier .

Community feedback

T
Grace 29,310

@grace-snow

Posted

You need to revisit html semantics. It's very important to use the appropriate elements.

Anything with a hover style in a design needs to use an interactive element (like an anchor tag)

And tables are only for tabular data, not an image and paragraph

Also revisit how and when to write alt text on images. If images are decorative, alt should be blank. If not, they should describe the image.

This doesnt fit on my phone screen. This is because you have given the card a width instead of max width, meaning it cannot shrink when it needs to. Similarly the image should not have a width or height. It should be display block with width 100%. This will let the image adapt to the size of the card and not overflow it.

I hope this helps you. Good luck

Marked as helpful

1

K.N8baron 20

@kawthar-tor

Posted

@grace-snow Thaank you so much I'll improve my code .

0
jimavictor 375

@jimavictor

Posted

Hello there! You did a great job on this project. Looking at your solution, I noticed you did not add the cursor: pointer; on active states(when a mouse is hovered).. And the UI doesn't really appear fully on screens with width 320px.

Above all, the design is really great. Keep up the good work. Hope this was helpful!

Marked as helpful

0

K.N8baron 20

@kawthar-tor

Posted

@jimavictor Thank you soooo much

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord