Dine site - Responsive site using React, SCSS, PostCSS, Vite

Community feedback

• 

  👾 Ekaterine Mitagvaria 👾•7,600

  @catherineisonlinePosted almost 2 years ago

  Hello 🙌🏻 Your solution looks great however here are a couple of things you can improve which I hope will be helpful! 😎

  First of all, your folder structure looks a bit confusing. I am not sure whether that's in purpose but usually on React I place styles and components of the same purpose in the same folder, much easier to understand. If you have 20 components in a separate folder and another 20 style files in another folder it's a bit complicated to search for the ones you need.

  1

  ---

  

  Martin Kamír•490

  @Martin-K-KamirPosted almost 2 years ago

  @catherineisonline Hey, thanks for sharing your opinion. For a project like this small, I didn't go with having too many react components and block/component level styles. With CSS/SCSS I wanted to take advantage of global css rules, inheritance, utility classes, macro-level layout structure and special cases do block level styles. That left me I have few CSS blocks/components to style. This means I don't have for example 20 react components to style and share the same folder. For a bigger project that has more than 20+ react components and had to style each component differently. Yes, I would use this approach. Also most of the time I have the project panel hidden and use the search panel to go into different files. So if they use the same naming convention its easy to find them and it's more easier with a small project like this one.

  0