Design comparison
Solution retrospective
Feedback welcome.
Community feedback
- @Daniel-BilodidPosted over 1 year ago
Hi, my congratulations you did a great job š
ššØš¦š šš¢š©š¬ ššØš« š²šØš®š« ššØšš š
š¹ You need to contain your <li> in <ul> or <ol>
The <ol> and <ul> elements are used for lists and they only can contain <li>. The only difference is that in the <ol> element, order matters
You can try something like this šØāš»
<ul><li> <a href="/electronic_keyboard">electronic keyboard</a> </li></ul>
I hope it was helpful, you are great, keep up the good work š
Marked as helpful1 - @sanba-anassPosted over 1 year ago
great job beautifuly executed š !
1 - @0xabdulkhaliqPosted over 1 year ago
Hello there š. Congratulations on successfully completing the challenge! š
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML š·ļø:
- This solution generates accessibility error reports due to
non-semantic
markup, which lack landmark for a webpage
- So fix it by replacing the element
<div id="root">
the with semantic element<main>
in yourindex.html
file to improve accessibility and organization of your page.
- What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like
<div>
or<span>
- They convey the structure of your page. For example, the
<main>
element should include all content directly related to the page's main idea, so there should only be one per page
HEADINGS ā ļø:
- And, this solution has also generated accessibility error report due to lack of level-one heading
<h1>
- Every site must want at least one
h1
element identifying and describing the main content of the page.
- An
h1
heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
- So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a
sr-only
class to hide it from visual users (it will be useful for visually impaired users)
I hope you find this helpful š Above all, the solution you submitted is great !
Happy coding!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord