Dictionary App using React, React Router, Storybook

Community feedback

• 

  Towkir Ahmed•280

  @towkirPosted over 1 year ago

  Great work, congrats on completing the challenge. Here are some feedback from my end:

  1. The overall spacing between elements can be reviewed against the design, such as the items in the font selector dropdown and the list items in the word meanings, seems like there are a bit much spaces than the design.
  2. The font selector can be closed whenever user clicks outside the selector.
  3. The color of the horizontal lines can be reviewed, seems a bit too prominent.
  4. The bold fonts are not being rendered (such as for the word in h1 should have been bold or weight: 700), apparently you used variable fonts, need to check on that.
  5. It is recommended to have a generic font name declared as a fallback, such as:

    font-family: 'Inconsolata', monospace;
    font-family: 'Inter', sans-serif;
    font-family: 'Lora', serif;
  

  Cheers !!

  0