Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Devfinder w/ styled components and TS

Desktop design screenshot for the GitHub user search app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Just any feedback would be good :) Decided to cut this one short as I was getting bored of the project lol

cheers

Community feedback

@salymk

Posted

The project looks nice and clean. So far I found a couple of things that you should look at:

  1. When I input some value and click the Enter button it does not submit the form. I have to click on the Search button in order to submit the form. What can you do:

    • Make the Wrapper component a form instead of a div.
      • Wrapper component: https://github.com/guilhermehto/frontendmentor/blob/main/challenges/github-user-search/src/components/SearchBar.tsx
  2. When I click on a link, it does not open a new tab, my personal preference is to open a new tab.

  • For example: <a href="google.com" target="_blank" rel="noreferrer noopener"> Google
</a>
  1. It's hard to inspect your code, I can't tell which elements are being styled because all of the classNames are not descriptive.
  • You can import styled components like this: import styled from "styled-components/macro"; in order to see descriptive classNames

Marked as helpful

2

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord