@salymk
Posted
The project looks nice and clean. So far I found a couple of things that you should look at:
-
When I input some value and click the Enter button it does not submit the form. I have to click on the Search button in order to submit the form. What can you do:
- Make the Wrapper component a form instead of a div.
- Wrapper component: https://github.com/guilhermehto/frontendmentor/blob/main/challenges/github-user-search/src/components/SearchBar.tsx
- Make the Wrapper component a form instead of a div.
-
When I click on a link, it does not open a new tab, my personal preference is to open a new tab.
- For example: <a href="google.com" target="_blank" rel="noreferrer noopener"> Google
- It's hard to inspect your code, I can't tell which elements are being styled because all of the classNames are not descriptive.
- You can import styled components like this: import styled from "styled-components/macro"; in order to see descriptive classNames
Marked as helpful
@guilhermehto
Posted
Cheers @salymk! Thanks for the in depth review, specially the part about styled-components/macro
:)