Desktop-first using flexbox

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted about 4 years ago

  Hey, Diem Thuy Huynh! 👋

  Nice job on this challenge! It looks good and responds well! 👍

  In addition to rfilenko's feedback, I suggest,

  • Setting the text-align property of the heading and subheading to center in the tablet and mobile layouts of your page.
  • Perhaps adding a wee bit of padding to the sides of the page in the mobile layout so that there's some space between the content and the edges of the screen.

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Diem Thuy Huynh•10

  @tmeidPosted about 4 years ago

  @ApplePieGiraffe thanks for your feedback. So helpful ^^~ .

  0
• 

  Roman Filenko•3,335

  @rfilenkoPosted about 4 years ago

  Hey, good job. Have a few tips for you:

  • .intro > ul > li > span > span - don't use some many selectors to target elements in css, usually one class is enough;
  • not sure what the issue is with the stars - would probably just use imgs or spans in a list (img as background).
  • you can try mobile-first approach on next project.

  Also you can look into sass or css variables. 😉 Cheers, Roman

  1

  ---

  

  Diem Thuy Huynh•10

  @tmeidPosted about 4 years ago

  @rfilenko Your tips are so useful for me. Thank you very much, I'd work on that ^^

  0